Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-enable calc function specs #1934

Merged
merged 5 commits into from
Sep 14, 2023
Merged

Re-enable calc function specs #1934

merged 5 commits into from
Sep 14, 2023

Conversation

nex3
Copy link
Contributor

@nex3 nex3 commented Sep 1, 2023 •
edited
Loading

See sass/sass#3504
See #1899

[skip dart-sass]

@nex3 nex3 requested a review from Goodwine September 1, 2023 01:08
This was referenced Sep 1, 2023
Merged
Open
Open
Goodwine
Goodwine approved these changes Sep 5, 2023
View reviewed changes
Copy link
Member

@Goodwine Goodwine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tests LGTM

spec/values/calculation/calc/error/syntax.hrx Show resolved Hide resolved
spec/values/calculation/calc/operator.hrx Show resolved Hide resolved
@nex3 nex3 mentioned this pull request Sep 13, 2023
Merged
@nex3 nex3 merged commit a27a1ed into main Sep 14, 2023
12 checks passed
@nex3 nex3 deleted the calc-functions branch September 14, 2023 00:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Goodwine Goodwine Goodwine approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nex3 @Goodwine